Allow dynamic batch sizes in all the layers #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,8 +18,10 @@ class Blob { | |||
| explicit Blob(const int num, const int channels, const int height, | |||
| const int width); | |||
| virtual ~Blob() {} | |||
| void Reshape(const int num, const int height, | |||
| const int width, const int channels); | |||
| void Reshape(const int num, const int channels, const int height, | |||
There was a problem hiding this comment.
Thank you for making this consistent with the internal indexing by N x K x H x W.
|
This is welcome flexibility! Please update us when tests pass so that we can assign a reviewer. Thanks. |
| void Reshape(const int num, const int channels, const int height, | ||
| const int width); | ||
| void ReshapeBigEnough(const int num, const int channels, const int height, | ||
| const int width); |
There was a problem hiding this comment.
Add comments for this function?
|
This needs to be revised to be consistent with #250. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practical applications, many users need to feed data of varying batch sizes into the network. The detailed design of this PR was formed in the discussion of #119.
#189 may involved similar but more complex blob memory operations, but this PR only focuses on batch size.
Many but not all the layers have passed the dynamic batch sizes test cases right now.