reduce lmdb mem map size from 1 TB to 128 MB for MNIST data #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lmdb memory map size was set to 1 TB, on Windows 10 this actually created a 1 TB file. Reduce it to 128 MB which is more than enough for this MNIST data.
|
Thanks @by321, 1TB does seem a bit much for MNIST... Please squash your history to a single commit and I'll merge. |
… created a 1 TB file. Reduce it to 128 MB which is more than enough for this MNIST data.
|
Is it squashed ? I'm not sure (git is too hard for me). |
|
@by321 see this gitready guide to squashing and try one more time. |
|
I did all that on my local computer, I think I even pushed the squashing commit to GitHub, but is it reflected in the PR ? How do I check ? Do I have to close this PR and make a new one ? |
|
@by321 you don't need to open a new PR; instead, force push ( |
This was referenced Feb 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce lmdb mem map size from 1 TB to 128 MB for MNIST data, on Windows 10 it actually created a 1 TB file.