Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed mnist map size, paths, file extensions #4003

Closed
wants to merge 2 commits into from

Conversation

joelself
Copy link

For the mnist example convert_mnist_data.cpp creates a 1 TB lmdb which fails if you don't have a terabyte to spare on your drive. I reduced it to 75 MB.

The scripts also assume that that executables will end with bin when on Windows they end with exe so I changed those too.

The location of binaries is different on Windows as well. I changed the path of the mnist examples to use the Windows path (the Release path, still won't work for Debug builds).

…les to exe instead of bin. Changed the paths of executables to match their output directories when built with visual studio, but only for Release.
@ajtulloch
Copy link
Contributor

-- /home/travis/build/BVLC/caffe/build/../examples/mnist/convert_mnist_data.cpp:101:  Tab found better to use spaces  [whitespace/tab] [1]
CMake Error at /home/travis/build/BVLC/caffe/cmake/lint.cmake:46 (message):
  Lint found 1 errors!
make[3]: *** [CMakeFiles/lint] Error 1
make[3]: Target `CMakeFiles/lint.dir/build' not remade because of errors.
make[2]: *** [CMakeFiles/lint.dir/all] Error 2
make[1]: *** [CMakeFiles/lint.dir/rule] Error 2

Looks fine except the lint error? Could you change tabs to spaces and update please?

@joelself
Copy link
Author

Sorry about that. I couldn't get NuGet to work properly and the only way to get it working was to completely reinstall Windows and VS and I hadn't yet turned on visible spaces/tabs.

I also fixed the comment that said "1 TB" to say "75 MB" instead.

@ajtulloch
Copy link
Contributor

Looks great. Could you squash into a single commit please?

@lukeyeager
Copy link
Contributor

For the mnist example convert_mnist_data.cpp creates a 1 TB lmdb which fails if you don't have a terabyte to spare on your drive. I reduced it to 75 MB.

Can we please merge #3731 instead of this temporary fix?

@shelhamer
Copy link
Member

#3731 does look to be a more general solution.

@joelself
Copy link
Author

I agree #3731 is a more comprehensive solution. Feel free to close this.

@shelhamer
Copy link
Member

Closing in favor of #3731 but thanks @joelself for raising the issue and contributing a local fix to remind us. If anyone can do a quick check of #3731 for their own IO that'd help.

@shelhamer shelhamer closed this Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants