Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix draw_net() and add a test #5477

Merged
merged 2 commits into from
Mar 31, 2017
Merged

Fix draw_net() and add a test #5477

merged 2 commits into from
Mar 31, 2017

Conversation

lukeyeager
Copy link
Contributor

@lukeyeager lukeyeager commented Mar 31, 2017 •
edited

Reverts #5010

A minimal but helpful improvement would be to add a Python test that imports caffe.draw and calls draw_net() to check that it at least runs without exception. That could be a good PR to encourage further testing.
@shelhamer #3201 (comment)

Done.

@lukeyeager
Copy link
Contributor Author

/cc @ngaloppo @StevenPuttemans

@shelhamer
Copy link
Member

Thanks Luke for fixing the fix (sorry about that everybody!) and finally adding a test to make sure this doesn't happen again.

@shelhamer shelhamer merged commit c0597b1 into BVLC:master Mar 31, 2017
@lukeyeager lukeyeager deleted the bvlc/test-draw-net branch March 31, 2017 20:40
@StevenPuttemans
Copy link

Thanks! 👍

shelhamer referenced this pull request Apr 4, 2017
@ngaloppo
Fix Python net drawing script
db6cf0a
@nitheeshas nitheeshas mentioned this pull request Apr 4, 2017
Merged
This was referenced Apr 12, 2017
Closed
Closed
Closed
Closed
Bardo91 pushed a commit to Bardo91/caffe that referenced this pull request Jun 1, 2017
Fixed python script for drawing nets following original issues BVLC#3698
12a5c3f 
 BVLC#5477 and BVLC#5487
@lukeyeager lukeyeager mentioned this pull request Jul 25, 2017
Closed
ethantang95 pushed a commit to ethantang95/caffe that referenced this pull request Jul 25, 2017
@ngaloppo @ethantang95
Fix for visualizing caffe models, cherry-picked PRs BVLC#5010, BVLC#5477
aca751e 
, BVLC#5487

from BVLC/caffe

Fix Python net drawing script

Revert "Fix Python net drawing script"

This reverts commit db6cf0a.

Add test for caffe.draw.draw_net()

Minor fix for net drawing script

Add main() for draw_net unittest, fix import errors
ethantang95 pushed a commit to ethantang95/caffe that referenced this pull request Jul 26, 2017
@ngaloppo @ethantang95
Fix for visualizing caffe models, cherry-picked PRs BVLC#5010, BVLC#5477
c3771c5 
, BVLC#5487

from BVLC/caffe

Fix Python net drawing script

Revert "Fix Python net drawing script"

This reverts commit db6cf0a.

Add test for caffe.draw.draw_net()

Minor fix for net drawing script

Add main() for draw_net unittest, fix import errors
drnikolaev added a commit to NVIDIA/caffe that referenced this pull request Jul 27, 2017
@drnikolaev
Merge pull request #377 from ethantang95/caffe-0.16
22970ac 
Fix for visualizing caffe models, cherry-picked PRs BVLC#5010, BVLC#5477, BVLC#5487 from BVLC/caffe
drnikolaev added a commit to NVIDIA/caffe that referenced this pull request Jul 27, 2017
@drnikolaev
Merge pull request #378 from ethantang95/caffe-0.15
391b05a 
Fix for visualizing caffe models, cherry-picked PRs BVLC#5010, BVLC#5477, BVLC#5487 from BVLC/caffe for caffe 0.15
@ascll82
Copy link

ascll82 commented Sep 29, 2017

it really works，thanks a lot！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukeyeager @shelhamer @StevenPuttemans @ascll82