Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-login warmup timer for rewards #48

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

Kali0033
Copy link
Contributor

This PR adds a configurable setting to have a warmup period required after login before reward can be claimed.

Changes in config.yml:
In days-display
` warmup:

  material: IRON_BLOCK:0:1

  name: '&c[Day #%day%] &7Time-Locked Reward'

  lore:

  - '%reward-lore%'

  - ''
  - 
  - '&c» &7Wait until &e%reward-warmup-remaining% &7while online to unlock!'`

In options
reward-login-delay: 0

Both setting changes follow the conventions established by other configuration options, feel free to let me know if there is anything off with this PR or improvements that could be made.

Adds a configurable setting to have a warmup period required after login before reward can be claimed.
@Kali0033 Kali0033 requested a review from NONPLAYT as a code owner June 23, 2023 04:43
@sonatype-lift
Copy link

sonatype-lift bot commented Jun 23, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/BX-Team/NDailyRewards/48.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/BX-Team/NDailyRewards/48.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

Copy link
Member

@NONPLAYT NONPLAYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing. im tested this feature and all works good.

@NONPLAYT NONPLAYT added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 23, 2023
@NONPLAYT NONPLAYT merged commit 1c6a5ee into BX-Team:master Jun 23, 2023
0 of 2 checks passed
NONPLAYT added a commit that referenced this pull request Jun 23, 2023
NONPLAYT added a commit that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants