Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI tests (fixes #4) #13

Merged
merged 1 commit into from Jul 2, 2019
Merged

Add CLI tests (fixes #4) #13

merged 1 commit into from Jul 2, 2019

Conversation

onurtemizkan
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e205cc8 on onurtemizkan:Add_CLI_tests into ad1313a on BYK:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e205cc8 on onurtemizkan:Add_CLI_tests into ad1313a on BYK:master.

BYK
BYK approved these changes Jul 9, 2017
View reviewed changes
Copy link
Owner

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Merge at will.

test/connoisseur.spec.js
const expect = chai.expect;

const connoisseur = require(path.join(__dirname, "..", "lib", "connoisseur.js"));

describe("connoisseur", () => {
describe("cli", () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check the exit code too.

@BYK BYK merged commit 059dd1c into BYK:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BYK BYK BYK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onurtemizkan @coveralls @BYK