Fix a few files that are not part of the regular dev build

BabylonJS · Apr 18, 2024 · 41bc488 · 41bc488
1 parent cb3992c
commit 41bc488
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/packages/tools/accessibility/src/HtmlTwin/htmlTwinGUIItem.ts b/packages/tools/accessibility/src/HtmlTwin/htmlTwinGUIItem.ts
@@ -15,7 +15,7 @@ export class HTMLTwinGUIItem extends HTMLTwinItem {
     /**
      * The corresponding BabylonJS entity. Can be a Node or a Control.
      */
-    public entity: Control;
+    public override entity: Control;
 
     constructor(entity: Control, scene: Scene) {
         super(entity, scene);

diff --git a/packages/tools/accessibility/src/HtmlTwin/htmlTwinHostComponent.tsx b/packages/tools/accessibility/src/HtmlTwin/htmlTwinHostComponent.tsx
@@ -22,7 +22,7 @@ export class HTMLTwinHostComponent extends React.Component<IHTMLTwinHostComponen
         };
     }
 
-    render() {
+    override render() {
         return (
             <div id={"accessibility-host"}>
                 <HTMLTwinSceneTree scene={this.props.scene} options={this._options} />

diff --git a/packages/tools/accessibility/src/HtmlTwin/htmlTwinNodeItem.ts b/packages/tools/accessibility/src/HtmlTwin/htmlTwinNodeItem.ts
@@ -13,7 +13,7 @@ export class HTMLTwinNodeItem extends HTMLTwinItem {
     /**
      * The corresponding BabylonJS entity. Can be a Node or a Control.
      */
-    public entity: Node;
+    public override entity: Node;
 
     constructor(entity: Node, scene: Scene) {
         super(entity, scene);

diff --git a/packages/tools/viewer/src/configuration/loader.ts b/packages/tools/viewer/src/configuration/loader.ts
@@ -4,7 +4,7 @@ import { getConfigurationType } from "./types/index";
 
 export class ConfigurationLoader extends RenderOnlyConfigurationLoader {
     // eslint-disable-next-line @typescript-eslint/naming-convention
-    protected getExtendedConfig(type: string | undefined) {
+    protected override getExtendedConfig(type: string | undefined) {
         return getConfigurationType(type || "extended");
     }
 }
diff --git a/packages/tools/viewer/src/viewer/defaultViewer.ts b/packages/tools/viewer/src/viewer/defaultViewer.ts
@@ -41,7 +41,7 @@ export class DefaultViewer extends AbstractViewerWithTemplate {
      * @param initialConfiguration the initial configuration. Defaults to extending the default configuration
      */
     constructor(
-        public containerElement: Element,
+        public override containerElement: Element,
         initialConfiguration: ViewerConfiguration = { extends: "default" }
     ) {
         super(containerElement, initialConfiguration);
@@ -118,7 +118,7 @@ export class DefaultViewer extends AbstractViewerWithTemplate {
      * This will be executed when the templates initialize.
      * @returns a promise that will be resolved when the templates are loaded
      */
-    protected _onTemplatesLoaded() {
+    protected override _onTemplatesLoaded() {
         this.showLoadingScreen();
 
         // navbar
@@ -411,7 +411,7 @@ export class DefaultViewer extends AbstractViewerWithTemplate {
         this._updateAnimationSpeed("1.0", paramsObject);
     };
 
-    protected _initVR() {
+    protected override _initVR() {
         if (this.sceneManager.vrHelper) {
             // due to the way the experience helper is exisintg VR, this must be added.
             this.sceneManager.vrHelper.onExitingVR.add(() => {
@@ -519,7 +519,7 @@ export class DefaultViewer extends AbstractViewerWithTemplate {
      * @param model the configuration object (or URL) to load.
      * @returns a promise that will be resolved when the model is loaded
      */
-    public async loadModel(model?: string | File | IModelConfiguration): Promise<ViewerModel> {
+    public override async loadModel(model?: string | File | IModelConfiguration): Promise<ViewerModel> {
         if (!model) {
             model = this.configuration.model;
         }
@@ -690,12 +690,12 @@ export class DefaultViewer extends AbstractViewerWithTemplate {
         });
     }
 
-    public dispose() {
+    public override dispose() {
         this.templateManager.dispose();
         super.dispose();
     }
 
-    protected _onConfigurationLoaded(configuration: ViewerConfiguration) {
+    protected override _onConfigurationLoaded(configuration: ViewerConfiguration) {
         super._onConfigurationLoaded(configuration);
 
         this.templateManager = new TemplateManager(this.containerElement);

diff --git a/packages/tools/viewer/src/viewer/viewerWithTemplate.ts b/packages/tools/viewer/src/viewer/viewerWithTemplate.ts
@@ -7,7 +7,7 @@ import { ConfigurationLoader } from "../configuration/loader";
  */
 export abstract class AbstractViewerWithTemplate extends AbstractViewer {
     // eslint-disable-next-line @typescript-eslint/naming-convention
-    protected getConfigurationLoader() {
+    protected override getConfigurationLoader() {
         return new ConfigurationLoader();
     }
 }