Fix babylon native sprites (#12819)

* fix native sprites * Babylon Native Sprites
BabylonJS · Aug 1, 2022 · 722457d · 722457d
1 parent 266c693
commit 722457d
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 1 deletion.
diff --git a/packages/dev/core/src/Engines/engineFeatures.ts b/packages/dev/core/src/Engines/engineFeatures.ts
@@ -66,6 +66,9 @@ export interface EngineFeatures {
     /**  Indicates that the engine supports render passes */
     supportRenderPasses: boolean;
 
+    /**  Indicates that the engine supports sprite instancing */
+    supportSpriteInstancing: boolean;
+
     /** @hidden */
     _collectUbosUpdatedInFrame: boolean;
 }
diff --git a/packages/dev/core/src/Engines/nativeEngine.ts b/packages/dev/core/src/Engines/nativeEngine.ts
@@ -927,6 +927,7 @@ export class NativeEngine extends Engine {
             needShaderCodeInlining: true,
             needToAlwaysBindUniformBuffers: false,
             supportRenderPasses: true,
+            supportSpriteInstancing: false,
             _collectUbosUpdatedInFrame: false,
         };
 

diff --git a/packages/dev/core/src/Engines/nullEngine.ts b/packages/dev/core/src/Engines/nullEngine.ts
@@ -178,6 +178,7 @@ export class NullEngine extends Engine {
             needShaderCodeInlining: false,
             needToAlwaysBindUniformBuffers: false,
             supportRenderPasses: true,
+            supportSpriteInstancing: false,
             _collectUbosUpdatedInFrame: false,
         };
 

diff --git a/packages/dev/core/src/Engines/thinEngine.ts b/packages/dev/core/src/Engines/thinEngine.ts
@@ -1399,6 +1399,7 @@ export class ThinEngine {
             needShaderCodeInlining: false,
             needToAlwaysBindUniformBuffers: false,
             supportRenderPasses: false,
+            supportSpriteInstancing: true,
             _collectUbosUpdatedInFrame: false,
         };
     }

diff --git a/packages/dev/core/src/Engines/webgpuEngine.ts b/packages/dev/core/src/Engines/webgpuEngine.ts
@@ -838,6 +838,7 @@ export class WebGPUEngine extends Engine {
             needShaderCodeInlining: true,
             needToAlwaysBindUniformBuffers: true,
             supportRenderPasses: true,
+            supportSpriteInstancing: true,
             _collectUbosUpdatedInFrame: false,
         };
     }

diff --git a/packages/dev/core/src/Sprites/spriteRenderer.ts b/packages/dev/core/src/Sprites/spriteRenderer.ts
@@ -102,7 +102,7 @@ export class SpriteRenderer {
         this._epsilon = epsilon;
 
         this._engine = engine;
-        this._useInstancing = engine.getCaps().instancedArrays;
+        this._useInstancing = engine.getCaps().instancedArrays && engine._features.supportSpriteInstancing;
         this._useVAO = engine.getCaps().vertexArrayObject && !engine.disableVertexArrayObjects;
         this._scene = scene;
         this._drawWrapperBase = new DrawWrapper(engine);