Merge pull request #3 from BabylonJS/master

Update from master
BabylonJS · Sep 7, 2022 · e9e5c8f · e9e5c8f
2 parents 006be27 + 06c1f55
commit e9e5c8f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 13 deletions.
diff --git a/packages/tools/tests/test/visualization/visualization.webgl1.test.ts b/packages/tools/tests/test/visualization/visualization.webgl1.test.ts
@@ -109,7 +109,9 @@ test /*.concurrent*/
             const renderCount = /*getGlobalConfig().qs && getGlobalConfig().qs.checkresourcecreation ? 50 : */ test.renderCount || 1;
             // await jestPuppeteer.debug();
 
-            expect(await page.evaluate(evaluateRenderSceneForVisualization, renderCount)).toBeTruthy();
+            const renderResult = await page.evaluate(evaluateRenderSceneForVisualization, renderCount);
+            debug && await jestPuppeteer.debug();
+            expect(renderResult).toBeTruthy();
 
             const glError = await page.evaluate(evaluateIsGLError);
             expect(glError).toBe(false);
@@ -129,5 +131,5 @@ test /*.concurrent*/
             expect(disposeResult).toBe(true);
         }
     },
-    40000
+    debug ? 1000000 : 40000
 );
diff --git a/packages/tools/tests/test/visualization/visualization.webgl2.test.ts b/packages/tools/tests/test/visualization/visualization.webgl2.test.ts
@@ -107,10 +107,11 @@ test /*.concurrent*/
             expect(await page.evaluate(evaluatePrepareScene, test, getGlobalConfig({ root: config.root }))).toBeTruthy();
 
             const renderCount = /*getGlobalConfig().qs && getGlobalConfig().qs.checkresourcecreation ? 50 : */ test.renderCount || 1;
-            // await jestPuppeteer.debug();
-
-            expect(await page.evaluate(evaluateRenderSceneForVisualization, renderCount)).toBeTruthy();
-
+
+            const renderResult = await page.evaluate(evaluateRenderSceneForVisualization, renderCount);
+            debug && await jestPuppeteer.debug();
+            expect(renderResult).toBeTruthy();
+
             const glError = await page.evaluate(evaluateIsGLError);
             expect(glError).toBe(false);
             // Take screenshot
@@ -129,5 +130,5 @@ test /*.concurrent*/
             expect(disposeResult).toBe(true);
         }
     },
-    40000
+    debug ? 1000000 : 40000
 );
diff --git a/packages/tools/tests/test/visualization/visualization.webgpu.test.ts b/packages/tools/tests/test/visualization/visualization.webgpu.test.ts
@@ -101,12 +101,10 @@ test /*.concurrent*/
             expect(await page.evaluate(evaluatePrepareScene, test, getGlobalConfig())).toBeTruthy();
 
             const renderCount = test.renderCount || 1;
-            // await jestPuppeteer.debug();
 
-            expect(await page.evaluate(evaluateRenderSceneForVisualization, renderCount)).toBeTruthy();
-
-            // const glError = await page.evaluate(evaluateIsGLError);
-            // expect(glError).toBe(false);
+            const renderResult = await page.evaluate(evaluateRenderSceneForVisualization, renderCount);
+            debug && await jestPuppeteer.debug();
+            expect(renderResult).toBeTruthy();
             // Take screenshot
             const screenshot = await page.screenshot();
 
@@ -123,5 +121,5 @@ test /*.concurrent*/
             expect(disposeResult).toBe(true);
         }
     },
-    600000
+    debug ? 1000000 : 600000
 );