RenderTargetWrapper: Make shareDepth visible (#14961)

* Make shareDepth visible * Fix visibility
BabylonJS · Apr 9, 2024 · ee02002 · ee02002
1 parent 0549f29
commit ee02002
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 8 deletions.
diff --git a/packages/dev/core/src/Engines/WebGL/webGLRenderTargetWrapper.ts b/packages/dev/core/src/Engines/WebGL/webGLRenderTargetWrapper.ts
@@ -113,11 +113,10 @@ export class WebGLRenderTargetWrapper extends RenderTargetWrapper {
 
     /**
      * Shares the depth buffer of this render target with another render target.
-     * @internal
      * @param renderTarget Destination renderTarget
      */
-    public _shareDepth(renderTarget: WebGLRenderTargetWrapper): void {
-        super._shareDepth(renderTarget);
+    public shareDepth(renderTarget: WebGLRenderTargetWrapper): void {
+        super.shareDepth(renderTarget);
 
         const gl = this._context;
         const depthbuffer = this._depthStencilBuffer;

diff --git a/packages/dev/core/src/Engines/renderTargetWrapper.ts b/packages/dev/core/src/Engines/renderTargetWrapper.ts
@@ -303,17 +303,25 @@ export class RenderTargetWrapper {
     }
 
     /**
-     * Shares the depth buffer of this render target with another render target.
-     * @internal
+     * @deprecated Use shareDepth instead
      * @param renderTarget Destination renderTarget
      */
     public _shareDepth(renderTarget: RenderTargetWrapper): void {
+        this.shareDepth(renderTarget);
+    }
+
+    /**
+     * Shares the depth buffer of this render target with another render target.
+     * @param renderTarget Destination renderTarget
+     */
+    public shareDepth(renderTarget: RenderTargetWrapper): void {
         if (this._depthStencilTexture) {
             if (renderTarget._depthStencilTexture) {
                 renderTarget._depthStencilTexture.dispose();
             }
 
             renderTarget._depthStencilTexture = this._depthStencilTexture;
+            renderTarget._depthStencilTextureWithStencil = this._depthStencilTextureWithStencil;
             this._depthStencilTexture.incrementReferences();
         }
     }

diff --git a/packages/dev/core/src/Materials/Textures/thinTexture.ts b/packages/dev/core/src/Materials/Textures/thinTexture.ts
@@ -151,7 +151,7 @@ export class ThinTexture {
     private _cachedBaseSize: ISize = Size.Zero();
 
     private static _IsRenderTargetWrapper(texture: Nullable<InternalTexture> | Nullable<RenderTargetWrapper>): texture is RenderTargetWrapper {
-        return (texture as RenderTargetWrapper)?._shareDepth !== undefined;
+        return (texture as RenderTargetWrapper)?.shareDepth !== undefined;
     }
 
     /**

diff --git a/packages/dev/core/src/Rendering/depthPeelingRenderer.ts b/packages/dev/core/src/Rendering/depthPeelingRenderer.ts
@@ -310,7 +310,7 @@ export class DepthPeelingRenderer {
             }
             this._thinTextures[6] = new ThinTexture(this._blendBackTexture);
 
-            prePassRenderer.defaultRT.renderTarget!._shareDepth(this._depthMrts[0].renderTarget!);
+            prePassRenderer.defaultRT.renderTarget!.shareDepth(this._depthMrts[0].renderTarget!);
         }
 
         return true;

diff --git a/packages/dev/core/src/Rendering/fluidRenderer/fluidRenderer.ts b/packages/dev/core/src/Rendering/fluidRenderer/fluidRenderer.ts
@@ -441,7 +441,7 @@ export class FluidRenderer {
                         if (!copyDepthTexture) {
                             copyDepthTexture = copyDepthTextures[key] = new FluidRenderingDepthTextureCopy(this._engine, thicknessTexture.width, thicknessTexture.height);
                         }
-                        copyDepthTexture.depthRTWrapper._shareDepth(thicknessRT);
+                        copyDepthTexture.depthRTWrapper.shareDepth(thicknessRT);
                     }
                 }
             });