Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning dialog when switching WebGL version in playground #13260

Closed
PatrickRyanMS opened this issue Nov 17, 2022 · 0 comments · Fixed by #13264
Closed

Add warning dialog when switching WebGL version in playground #13260

PatrickRyanMS opened this issue Nov 17, 2022 · 0 comments · Fixed by #13264
Labels
enhancement Playground

Comments

@PatrickRyanMS
Copy link
Member

Switching between WebGL and WebGL2 causes a playground reload without warning. Can we instantiate the same warning dialog used for switching engine version? The warning text is generic enough to apply to the engine version or the WebGL version, so we shouldn't need anything custom here.

image
@sebavan sebavan mentioned this issue Nov 17, 2022
Merged
RaananW pushed a commit that referenced this issue Dec 9, 2022
@sebavan
Fix #13260 Add confirmation message in PG
6b1a4d1 
Former-commit-id: 35ffbe3f74a94101494fdd49d26b1b481edba0fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add confirmation message in PG when switching version
1 participant
@PatrickRyanMS