Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable vr interaction controller when gamepad is disconnected #6853

Closed
RaananW opened this issue Sep 16, 2019 · 1 comment
Closed

Disable vr interaction controller when gamepad is disconnected #6853

RaananW opened this issue Sep 16, 2019 · 1 comment
Assignees
Milestone

Comments

@RaananW
Copy link
Member

RaananW commented Sep 16, 2019

This is mainly an issue of the oculus quest, thou it is a bug that needs to be fixed.

When a gamepad is disconnected, the vr interaction controller that was enabled here - https://github.com/BabylonJS/Babylon.js/blob/master/src/Cameras/VR/vrExperienceHelper.ts#L1411 is not being disabled. the gamepad is disposed without taking care of the interaction controller, which leads to multiple events executed when the gamepad is reconnected and vr mode is still on (again, at the moment only an issue with the oculus quest).

EDIT

The function that needs to be reverted is this - https://github.com/BabylonJS/Babylon.js/blob/master/src/Cameras/VR/vrExperienceHelper.ts#L1388 to take transportation into account as well.

@RaananW RaananW added this to the 4.1 milestone Sep 16, 2019
@RaananW RaananW self-assigned this Sep 16, 2019
@deltakosh
Copy link
Contributor

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants