Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XR] Lighting Estimation Feature #8904

Closed
ankitcsr opened this issue Sep 8, 2020 · 1 comment
Closed

[XR] Lighting Estimation Feature #8904

ankitcsr opened this issue Sep 8, 2020 · 1 comment
Assignees
@RaananW
Labels
enhancement VR/AR/XR
Milestone
5.0

Comments

@ankitcsr
Copy link

ankitcsr commented Sep 8, 2020

https://immersive-web.github.io/lighting-estimation/
@deltakosh deltakosh added this to the 4.2 milestone Sep 8, 2020
@RaananW RaananW changed the title [XR] Request to add WebXR Lighting Estimation Feature [XR] Lighting Estimation Feature Sep 14, 2020
@RaananW RaananW modified the milestones: 4.2, Future, 5.0 Oct 27, 2020
@bghgary bghgary mentioned this issue May 14, 2021
Open
@brianzinn
Copy link
Contributor

I've started a branch:
brianzinn@ebd1f40

I'll work to get the getReflectionCubeMap and LightingEstimate (primaryLightDirection/primaryLightIntensity and sphericalHarmonicsCoefficients).

I will get the XR feature to the point of making the data available. One thing to note is that I think the babylon SphericalHarmonics is to order^2 and I think it would need to support order ^3 with the 27 element array, but I haven't checked thoroughly.

@brianzinn brianzinn mentioned this issue Jun 4, 2021
Closed
@RaananW RaananW mentioned this issue Sep 20, 2021
Merged
@sebavan sebavan closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaananW RaananW

Labels
enhancement VR/AR/XR
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
5 participants
@brianzinn @deltakosh @RaananW @sebavan @ankitcsr