Fix create instance line mesh #10807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Popov72
approved these changes
Aug 4, 2021
src/Meshes/linesMesh.ts
Outdated
| @@ -263,7 +263,17 @@ export class LinesMesh extends Mesh { | |||
| * @returns a new InstancedLinesMesh | |||
| */ | |||
| public createInstance(name: string): InstancedLinesMesh { | |||
| return new InstancedLinesMesh(name, this); | |||
| let instance = new InstancedLinesMesh(name, this); | |||
src/Meshes/linesMesh.ts
Outdated
| if (this.instancedBuffers) { | ||
| instance.instancedBuffers = {}; | ||
|
|
||
| for (var key in this.instancedBuffers) { |
| instance.instancedBuffers = {}; | ||
|
|
||
| for (var key in this.instancedBuffers) { | ||
| instance.instancedBuffers[key] = this.instancedBuffers[key]; |
There was a problem hiding this comment.
I think you should set it to null instead, as it is done in Mesh.registerInstancedBuffer. Else the instance will use the same attributes than the master.
There was a problem hiding this comment.
It is actually a copy paste from instancedMeshFactory :-)
Mesh._instancedMeshFactory = (name: string, mesh: Mesh): InstancedMesh => {
let instance = new InstancedMesh(name, mesh);
if (mesh.instancedBuffers) {
instance.instancedBuffers = {};
for (var key in mesh.instancedBuffers) {
instance.instancedBuffers[key] = mesh.instancedBuffers[key];
}
}
return instance;
};
There was a problem hiding this comment.
Ok, my mistake, I thought instancedBuffers were vertex buffers but they are custom data instead, that can be overwritten afterward by the user!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.babylonjs.com/t/instance-color-alpha-for-linesmesh/22812