Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the WebXRNearInteraction/WebXRPointerSelection class interaction #11301

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

rickfromwork
Copy link
Contributor

Changing the WebXRNearInteraction class to enable/disable WebXRControllerPointerSelection's class on a per-controller basis.

This prevents the user from getting in to unexpected situations when multiple hands are involved, such as an idle hand influencing whether the other hand can interact with objects via near interaction.

This also reduces potential noise from calling attach/detach on the WebXRControllerPointerSelection feature every time a near interaction starts/ends.

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebavan sebavan merged commit ef2c76f into BabylonJS:master Oct 19, 2021
@rickfromwork rickfromwork deleted the nearPointerCompat branch October 19, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebXRNearInteraction doesn't properly override WebXRControllerPointerSelection with two hands up
3 participants