Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to export fileTools, it is exported in LTS #11302

Merged
merged 1 commit into from
Oct 19, 2021
Merged

No need to export fileTools, it is exported in LTS #11302

merged 1 commit into from
Oct 19, 2021

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 19, 2021

No description provided.

sebavan
sebavan approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not break current ES6 users importing from filetools ? probably needs a quick breaking change in the doc

@RaananW
Copy link
Member Author

RaananW commented Oct 19, 2021

Filetools is actually a hidden public and should not be used directly. So it is not a breaking change...

@RaananW RaananW merged commit 00a22ef into BabylonJS:master Oct 19, 2021
@RaananW RaananW deleted the fixFileToolsExport branch October 19, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RaananW @sebavan