Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning when using ignored options with Dashed Lines update. #12509

Merged
merged 3 commits into from
May 16, 2022
Merged

Add a warning when using ignored options with Dashed Lines update. #12509

merged 3 commits into from
May 16, 2022

Conversation

carolhmj
Copy link
Contributor

From: https://forum.babylonjs.com/t/dashed-line-not-correctly-updated/29250 this is to make the behavior clearer to users.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12509/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12509/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12509/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12509/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12509/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12509/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12509/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12509/merge#BCU1XR#0

sebavan
sebavan requested changes May 11, 2022
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one tiny comment

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12509/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12509/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12509/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12509/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12509/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12509/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12509/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12509/merge#BCU1XR#0

@sebavan sebavan merged commit 0f10b73 into master May 16, 2022
@sebavan sebavan deleted the add-warn-dashed-lines branch May 16, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

@darraghjburke darraghjburke Awaiting requested review from darraghjburke

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carolhmj @darraghjburke @sebavan