Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GE] Make sure artboard is resized correctly when resizing the canvas #12828

Merged
merged 2 commits into from
Aug 3, 2022
Merged

[GE] Make sure artboard is resized correctly when resizing the canvas #12828

merged 2 commits into from
Aug 3, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Aug 3, 2022

There seems to be a race condition between the HTML page and the babylon scene/engine.
I will create an issue to follow up on this and find a proper fix, but for now, it is enough to run the rezise callback 5 times every time it is needed.

For future reference, there seems to be an issue with the top on the Rect created in ArtBoardComponent

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW enabled auto-merge (squash) August 3, 2022 16:34
@azure-pipelines
Copy link

@RaananW RaananW merged commit e15d49e into BabylonJS:master Aug 3, 2022
@RaananW RaananW deleted the updateArtBoardOnResize branch August 4, 2022 12:17
RaananW added a commit that referenced this pull request Dec 9, 2022
…#12828)

* Run resize more than one single frame when needed

* formatting

Former-commit-id: 110c1c7af66d90e572e3b1a9793c82fb928f070c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants