-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CSS Modules in Graph System #12948
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me aside of the tiny issue :-) but I ll let @RaananW do the final review
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12948/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12948/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12948/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for that :-)
I just want to be sure that it doesn't influence the existing tools before merging. Does it change anything in the node editor/gui editor? As it was previously globally applied, it is possible that those classes that were removed are used in one of the tools.
Otherwise - approved, great work
Great point! I was already testing with the node editor, and tested with the GUI editor now and everything seems to be on the right place 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me, @RaananW can we merge it ?
I'll wait with the merge until azure is stable, but yes, we can merge |
Use CSS Modules in Graph System Former-commit-id: a0a47aadd38d44a76a31a909d7e1ac43776d6cc1
This is part of the work to make the graph system more reusable.