-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce autoFixFaceOrientation feature to solidParticleSystem #12960
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12960/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12960/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12960/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :-) just need to fix the formatting and it should be good to go.
@RaananW any thoughts?
Thanks :) When the pipeline passes I will mark this PR ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Introduce autoFixFaceOrientation feature to solid particle system * Fix formatting * Do not clear indices when autoFixFaceOrientation is enabled Former-commit-id: daa6f1bfa8fcb779d382f7392104c0f09fa6ab42
What:
Introduce an option to "autofix face orientation" in solid particle system
How
When there is a transformation which changes the orientation (for example scaling
(-1, 1, 1)
), the solid particle system will automatically flip all the faces of the particle affected by this transformation.Why
I needed this functionality in my application, so I decided to make a PR and hope that it will get into the babylon itself :D
Example
https://playground.babylonjs.com/#GLZ1PX#714
in this example, the cone on the right has flipped faces. Using the new flag will fix this issue.