Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce autoFixFaceOrientation feature to solidParticleSystem #12960

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

Michalzr
Copy link
Contributor

@Michalzr Michalzr commented Sep 7, 2022

What:
Introduce an option to "autofix face orientation" in solid particle system

How
When there is a transformation which changes the orientation (for example scaling (-1, 1, 1)), the solid particle system will automatically flip all the faces of the particle affected by this transformation.

Why
I needed this functionality in my application, so I decided to make a PR and hope that it will get into the babylon itself :D

Example
https://playground.babylonjs.com/#GLZ1PX#714
in this example, the cone on the right has flipped faces. Using the new flag will fix this issue.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@Michalzr Michalzr marked this pull request as draft September 7, 2022 14:58
@azure-pipelines
Copy link

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-) just need to fix the formatting and it should be good to go.

@RaananW any thoughts?

@Michalzr
Copy link
Contributor Author

Michalzr commented Sep 8, 2022

Looks good to me :-) just need to fix the formatting and it should be good to go.

@RaananW any thoughts?

Thanks :)
I fixed the formatting, added a jsdoc for the new parameter and fixed a bug.

When the pipeline passes I will mark this PR ready for review

@Michalzr Michalzr marked this pull request as ready for review September 8, 2022 07:27
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaananW RaananW merged commit 8eb9f1e into BabylonJS:master Sep 8, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
* Introduce autoFixFaceOrientation feature to solid particle system

* Fix formatting

* Do not clear indices when autoFixFaceOrientation is enabled

Former-commit-id: daa6f1bfa8fcb779d382f7392104c0f09fa6ab42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants