Create mrtkv3 button [Contnued] #12989
Conversation
… user/chinezenwosu/create-mrtkv3-button
… user/chinezenwosu/create-mrtkv3-button
…/create-mrtkv3-button
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12989/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12989/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12989/merge#BCU1XR#0 |
There was a problem hiding this comment.
A few nits and a general question -
The PR contains a lot of static values that cannot be changed - colors, sizes, scaling factors, positions and so on. Shouldn't the dev be able to change these values if required?
Same thing in the animations loop - there are many static values there that are unconfigurable
Otherwise - LGTM
packages/dev/gui/src/3D/materials/mrdl/mrdlFrontplateMaterial.ts
Outdated
Show resolved
Hide resolved
packages/dev/gui/src/3D/materials/mrdl/mrdlFrontplateMaterial.ts
Outdated
Show resolved
Hide resolved
packages/dev/gui/src/3D/controls/MRTKv3/touchHolographicButton.ts
Outdated
Show resolved
Hide resolved
packages/dev/gui/src/3D/controls/MRTKv3/touchHolographicButton.ts
Outdated
Show resolved
Hide resolved
packages/dev/gui/src/3D/controls/MRTKv3/touchHolographicButton.ts
Outdated
Show resolved
Hide resolved
* create vertex and fragment shaders for different parts of button * create materials for different parts of button * create v3button class * add new line at end of backglow material file * update property docs for used materials * remove unused pinched property from frontplate * fix lint issues with prettier * fix right hand system problem with button animations * align text and image for button horizontally * use common radius and offset for frontplate and innerquad * use absolute sizing for backplate material * prettier fix spacing * move import to top * rename V3Button to TouchHolographicV3Button * adjust radius of innerquad * adjust positioning for quad, frontplate and glow * group private variables * fix bug with collision size * fix positioning of frontplate, innerquad and backglow * align text and image according to width to height ratio * adjust button text padding * update comment for tooltiptext * use grid for text and subtext instead of stackpanel * rename speed to speedRatio * prettier format * add observers for pointer enter and pointer out * fix issue with isBackplateVisible behaviour * fix toggle interaction issue * change design for tooltip * format fix * move MRTKv3 components to its own folder * code fixes and cleanup * nits + PR comments * use MRTK3 name format * fix code comment * fix lint issues Co-authored-by: Chineze Nwosu <chinezenwosu@microsoft.com> Former-commit-id: 2e37e3d95161fa2a564d55b38b2f21a33d3f7197
This is a continuation of the work started in this PR: #12707:
Assets PR: BabylonJS/Assets#67
Preview:
The design team is currently working on creating an interactive documentation for showcasing graphics tools components. This PR creates a TouchHolographicV3Button which mirrors the visual design of the MRTK v3.0 button.
For the time being, we would be using snapshots from this experimental PR and other PRs to create this documentation pending when we figure out the best way to release these new designs.
TODO
Playground ID - /#UHMKE6#1