Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU: Fix geometry buffer renderer in WebGPU #12991

Merged
merged 1 commit into from
Sep 19, 2022
Merged

WebGPU: Fix geometry buffer renderer in WebGPU #12991

merged 1 commit into from
Sep 19, 2022

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Sep 17, 2022

In WebGPU (WGSL), if you declare some uniforms in the shader code (even if you don't use those uniforms in the code itself) the drawing code must set their values and can't leave them empty.

So, the declarations must be guarded by some #ifdef to make sure the uniforms we don't set values for are not declared in the shader code.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit ef0d2e1 into BabylonJS:master Sep 19, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
WebGPU: Fix geometry buffer renderer in WebGPU
Former-commit-id: 85a344ae13de73b1aeead9dbf1a9602efee9ce2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants