test(particles.cloudPoint): add tests for intersectsMesh function #12992
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12992/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12992/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12992/merge#BCU1XR#0 |
…2992) Former-commit-id: 0fbcdf2523a7d23f9e6f77d8f403f753fdd6c8ad
Hi!
I add some tests to Particles/cloudPoint, the function is intersectsMesh.
Here I found some points.
meshhas incorrect type. In fact this property may haveundefinedas value, because it's not defined in the constructor. So I add optional mark?to type and required checks in the class.intersectsMeshfunction did not check the mesh property existing in the point cloud system. So I add a new Error here, that notice about required mesh to next calculations.isSphere = isSphere ? isSphere : false;look like redundant, because TypeScript promise that it have boolean type.const bbox = target.getBoundingInfo().boundingBox;. It's look for me as potential performance boost, maybe.elsebranch because it rendundant because the code above have return statements.And I limited test cases from 729 possible combinations to 126, they seems like corner cases for me. I dont know which cases we can reduce to save the working guarantee.