Add function to get angles between two vectors (Vector3.GetAnglesBetweenVectorsForDirectionChange)

[james-pre]

Also add prettier settings to workspace settings.

See this PR for more details.

Demo PGs:
https://playground.babylonjs.com/#QYA3JC#25
https://playground.babylonjs.com/#QYA3JC#26
(Press space to start)

@BabylonJSGuide
I have the opportunity to talk with a physicist almost every day of the week, so I asked him about the problem and worked out the same equations used. After researching how Math.atan2 works though, and found an issue with the equations: for the phi calculation, the diff.y should have been the second parameter of Math.atan2, not the first.

[sebavan]

Is it not similar to #13004

cc @RaananW for prettier

[azure-pipelines]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[james-pre]

Is it not similar to #13004

@sebavan,
How is this related to #13004?

Edit: Read #13004. I have some feedback though I will put in on that PR.

[azure-pipelines]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[sebavan]

Is it not similar to #13004

@sebavan, How is this related to #13004?

RotationQuaternionFromOntoToRef seems to be doing the exact same finding the required rotation bewtween two vectors.

[azure-pipelines]

Snapshot stored with reference name:
refs/pull/13012/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13012/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13012/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13012/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13012/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13012/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13012/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13012/merge#BCU1XR#0

[james-pre]

RotationQuaternionFromOntoToRef seems to be doing the exact same finding the required rotation bewtween two vectors.

https://playground.babylonjs.com/#QYA3JC#24 It does not seem to work.

[sebavan]

RotationQuaternionFromOntoToRef seems to be doing the exact same finding the required rotation bewtween two vectors.

https://playground.babylonjs.com/#QYA3JC#24 It does not seem to work.

Let s figure it out and only keep one implementation. We need to be careful and prevent duplicated features.

[james-pre]

Agreed, could we maybe move it to this PR?

I'd like to know what @BabylonJSGuide thinks of this PR since we worked on it in #12942.

[sebavan]

Not sure it should be moved in this PR, lets compare the functionalities and keep the one closest from the goal. You can check with @BabylonJSGuide.

[BabylonJSGuide]

@dr-vortex now understand the difference - yours deals with positions mine with directions.

Suggestions

1. A better name would be pitchYawRollToMoveBetweenPoints(point0, point1)

2. Change comment from

• Gets the angles between two vectors needed to change direction

to something like

• gets the pitch, yaw, roll that enables a mesh/object(?) to move along a straight line between two points (vector3)

4. Possibly add an optional roll parameter, ie pitchYawRollToMoveBetweenPoints(point0, point1, roll?) which would default to zero but could be updated by the user to affect the roll as it follows the curve.

Need to wait to see if @RaananW and @sebavan think there is sufficient differences between both and/or between existing methods for none, one or both to be approved.

[james-pre]

Yes, I've been thinking about it with positions. For your 4th point, I had originally included an offset in #12942 but removed it. I agree we should wait to see if they should be implemented separately.

[sebavan]

Ok both PR fills different needs and are valid. Let s just rename and document more in this one what the fonction is for and good to go.

Would be great to attach unit tests as well if you can to ensure we do not regress later on ?

[sebavan]

Let s validate the naming and doc comment with @BabylonJSGuide and ready to ship :-)

[james-pre]

Sounds good!

[azure-pipelines]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13012/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

[BabylonJSGuide]

After a succesful build and before approval at least the following snapshot PG should be tested

https://playground.babylonjs.com/?snapshot=refs/pull/13012/merge#S7HDGQ#5

[sebavan]

@dr-vortex I ll merge as soon as @BabylonJSGuide comments have been addressed.

Thanks a lot you both !!!