Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forceSharedVertices with skinmesh support #13114

Merged
merged 2 commits into from
Oct 14, 2022
Merged

forceSharedVertices with skinmesh support #13114

merged 2 commits into from
Oct 14, 2022

Conversation

CedricGuillemet
Copy link
Contributor

forceSharedVertices didn't support skin mesh infos which results in glitched mesh rendering.
For example this PG:
https://playground.babylonjs.com/#92Y727#293

@RaananW RaananW enabled auto-merge (squash) October 14, 2022 13:10
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13114/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13114/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13114/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13114/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13114/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13114/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13114/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13114/merge#BCU1XR#0

Popov72
Popov72 requested changes Oct 14, 2022
View reviewed changes
packages/dev/core/src/Meshes/mesh.ts Outdated Show resolved Hide resolved
@sebavan sebavan disabled auto-merge October 14, 2022 15:57
@sebavan sebavan merged commit 00ca08f into BabylonJS:master Oct 14, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13114 from CedricGuillemet/forceSharedVerticesSki…
bac9bd0 
…nmesh

forceSharedVertices with skinmesh support

Former-commit-id: d12e82a7c48eb0d6c7c35cbf8f638a747882871c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 requested changes

@RaananW RaananW RaananW approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CedricGuillemet @RaananW @Popov72 @sebavan @CedricGuillemetMS