-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vsm state view wip #13124
Vsm state view wip #13124
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13124/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13124/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13124/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing :-)
I will pull this branch later and see it locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookg great! I think it will be important to say that this is not yet usable (since this is public code!). and that it is a WIP.
Maybe even change the version in package.json to 0.0.1 and add description just to be sure that no one pulls this and tries using it :-)
Reviewer - this PR has made changes to one or more package.json files. |
Vsm state view wip Former-commit-id: 1452c2ce4b58eee650fb1c74ef0e9c5e48a427dc
This adds basic nodes view and a very very simple state implementation that only responds to click events on a basic scene.