Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vsm state view wip #13124

Merged
merged 41 commits into from
Oct 25, 2022
Merged

Vsm state view wip #13124

merged 41 commits into from
Oct 25, 2022

Conversation

carolhmj
Copy link
Contributor

This adds basic nodes view and a very very simple state implementation that only responds to click events on a basic scene.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing :-)

I will pull this branch later and see it locally

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookg great! I think it will be important to say that this is not yet usable (since this is public code!). and that it is a WIP.
Maybe even change the version in package.json to 0.0.1 and add description just to be sure that no one pulls this and tries using it :-)

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@sebavan sebavan merged commit ccbcb43 into BabylonJS:master Oct 25, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Vsm state view wip 

Former-commit-id: 1452c2ce4b58eee650fb1c74ef0e9c5e48a427dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants