Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation gizmos with non uniform scaling #13240

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Rotation gizmos with non uniform scaling #13240

merged 5 commits into from
Nov 15, 2022

Conversation

CedricGuillemet
Copy link
Contributor

fixes #13112

Using rotation gizmo with non uniform scaling is a problem because gizmos work on nodes + world matrix and it's not possible in the case of updateGizmoRotationToMatchAttachedMesh to decompose/recompose properly the world matrix.
In that case, a warning is displayed.
Otherwise, the rotation amount is applied in the correct order on the world matrix and the rest of the operations can be done without issue.
If anyone finds a way to circumvent the warning and apply the rotation, I'm all ears :)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

packages/dev/core/src/Gizmos/planeRotationGizmo.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Gizmos/gizmo.ts Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

@RaananW RaananW merged commit 0be811d into BabylonJS:master Nov 15, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
* Rotation gizmos with non uniform scaling

* code format

* epsilon import

* tmpvectors and less GC

Co-authored-by: Cedric Guillemet <ceguille@microsoft.com>
Former-commit-id: 1828deb5934eeda962e770b44bbc9c45bf2129a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non uniform scaling and gizmos
5 participants