Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBRBaseMaterial fix getAnimatables JSDoc #13288

Merged
merged 2 commits into from
Nov 28, 2022
Merged

PBRBaseMaterial fix getAnimatables JSDoc #13288

merged 2 commits into from
Nov 28, 2022

Conversation

Dok11
Copy link
Contributor

@Dok11 Dok11 commented Nov 26, 2022

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13288/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13288/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13288/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13288/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13288/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13288/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13288/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13288/merge#BCU1XR#0

@sebavan sebavan merged commit 35cf097 into BabylonJS:master Nov 28, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13288 from Dok11/pbrbasematerial-fix-getanimatabl…
cd7321c 
…e-jsdoc

PBRBaseMaterial fix getAnimatables JSDoc

Former-commit-id: 4f16ae5a910091fba4979b729ec180d0f667bb40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dok11 @Popov72 @sebavan