Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the KHR_texture_transform exporter when exporting a GLTF file #13305

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Call the KHR_texture_transform exporter when exporting a GLTF file #13305

merged 4 commits into from
Dec 5, 2022

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Dec 1, 2022

Related issue: https://forum.babylonjs.com/t/glb-export-uv-mapping-not-saving/36140
You can use this playground that exports and imports some textured planes to compare the expected results: https://playground.babylonjs.com/#20OAV9#9228 (also added as a visualization test)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan requested a review from bghgary December 1, 2022 17:13
@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13305/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@carolhmj carolhmj requested a review from bghgary December 1, 2022 20:20
…ransform.ts

Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@sebavan
Copy link
Member

sebavan commented Dec 2, 2022

@carolhmj only a quick lint/format to fix and Good to Go

@sebavan sebavan merged commit 2c0d58a into BabylonJS:master Dec 5, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Call the KHR_texture_transform exporter when exporting a GLTF file

Former-commit-id: 7c7af689a4c3122362e24a62519238090ee3260f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants