-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call the KHR_texture_transform exporter when exporting a GLTF file #13305
Call the KHR_texture_transform exporter when exporting a GLTF file #13305
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13305/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13305/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13305/merge#BCU1XR#0 |
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
packages/dev/serializers/src/glTF/2.0/Extensions/KHR_texture_transform.ts
Outdated
Show resolved
Hide resolved
…ransform.ts Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@carolhmj only a quick lint/format to fix and Good to Go |
packages/dev/serializers/src/glTF/2.0/Extensions/KHR_texture_transform.ts
Outdated
Show resolved
Hide resolved
Call the KHR_texture_transform exporter when exporting a GLTF file Former-commit-id: 7c7af689a4c3122362e24a62519238090ee3260f
Related issue: https://forum.babylonjs.com/t/glb-export-uv-mapping-not-saving/36140
You can use this playground that exports and imports some textured planes to compare the expected results: https://playground.babylonjs.com/#20OAV9#9228 (also added as a visualization test)