Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fullscreen ADT to HTMLTwinRenderer #13325

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Add Fullscreen ADT to HTMLTwinRenderer #13325

merged 5 commits into from
Dec 8, 2022

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Dec 7, 2022

Currently the HTMLTwinRenderer won't render a fullscreen ADT. This PR adds this capability.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13325/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13325/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13325/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13325/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13325/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13325/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13325/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13325/merge#BCU1XR#0

@carolhmj carolhmj requested a review from Popov72 December 8, 2022 12:53
@sebavan sebavan merged commit 97c084c into BabylonJS:master Dec 8, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13325 from carolhmj/addfullscreenadttotwinrenderer
35c3e4f 
Add Fullscreen ADT to HTMLTwinRenderer 

Former-commit-id: ddf14c550a1c368851695043766652b676676975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

@sebavan sebavan sebavan approved these changes

@RaananW RaananW Awaiting requested review from RaananW

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carolhmj @RaananW @Popov72 @sebavan