Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of text height in InputTextArea #13404

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Jan 4, 2023

The variables used to calculate where the text's y position would be in the InputTextArea were not using the most up-to-date measure of the control, so the position would be incorrect inside a scroll view:
image
With the fix:
image

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 4, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 4, 2023

@sebavan sebavan requested a review from RaananW January 4, 2023 16:53
@sebavan sebavan merged commit cb27184 into BabylonJS:master Jan 4, 2023
@carolhmj carolhmj deleted the GUIFixTextHeightInputTextArea branch July 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants