Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XR] Remove a 180 degree flip (an old relic) #13448

Merged
merged 1 commit into from Jan 18, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jan 18, 2023

Fixes #13447

When initially implemented, right-handed scenes needed a 180 degrees flip because of the way teleportation was working. This code was revamped, but the 180 flip was never removed. I have tested it in different scenarios (and will continue testing it), but it does seem like this is an old relic and technically a bug that needs to be fixed.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2023

@RaananW RaananW changed the title [XR] Remove a 180 degree flip (and old relic) [XR] Remove a 180 degree flip (an old relic) Jan 18, 2023
@sebavan sebavan merged commit 5df3185 into BabylonJS:master Jan 18, 2023
@RaananW RaananW deleted the rightHandedXR branch March 6, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XR] Right-handed camera doesn't show follow-menu correctly
4 participants