Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wrapNativeTexture and wrapWebGLTexture with explicit hasMipMaps and samplingMode #13574

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Mar 1, 2023

This is necessary so that the sampling mode will default to something as opposed to some arbitrary default behavior of the underlying rendering API.

@bghgary bghgary requested a review from sebavan March 1, 2023 00:19
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 1, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 1, 2023

@sebavan sebavan merged commit 38d1cdb into BabylonJS:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants