Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR2: more improvements #13631

Merged
merged 25 commits into from
Mar 15, 2023
Merged

SSR2: more improvements #13631

merged 25 commits into from
Mar 15, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Mar 14, 2023

Add new features and fix some bugs.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 15, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 15, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 15, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13631/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 15, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13631/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG this is perfect only 2 stupid questions :-)

@Popov72
Copy link
Contributor Author

Popov72 commented Mar 15, 2023

I have also added support for SSR in the inspector.

@sebavan sebavan merged commit 9d54f04 into BabylonJS:master Mar 15, 2023
@Popov72 Popov72 deleted the ssr2-improve branch April 20, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants