Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no premature result mutation for Vec2.rotateToRef #13748

Merged
merged 1 commit into from Apr 18, 2023

Conversation

nekochanoide
Copy link
Contributor

for next case:

const vec = new Vector2(offsetX, offsetY);
vec.rotateToRef(angle, vec);

for next case:
```
const vec = new Vector2(offsetX, offsetY);
vec.rotateToRef(angle, vec);
```
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 18, 2023

@RaananW RaananW merged commit 3e2ec14 into BabylonJS:master Apr 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants