Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physics Iteration 13 #13749

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Physics Iteration 13 #13749

merged 6 commits into from
Apr 19, 2023

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Apr 18, 2023 •
edited

A big portion of this change has already been reviewed.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 18, 2023

Snapshot stored with reference name:
refs/pull/13749/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13749/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13749/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13749/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13749/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13749/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13749/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13749/merge#BCU1XR#0

sebavan
sebavan previously requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the import path should be changed ?

packages/dev/core/src/Meshes/thinInstanceMesh.ts Show resolved Hide resolved
packages/dev/core/src/Physics/physicsHelper.ts Show resolved Hide resolved
packages/dev/core/src/Physics/v2/physicsAggregate.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/v2/physicsAggregate.ts Outdated Show resolved Hide resolved
RaananW
RaananW approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got a few nit-picks that can be taken care of later

@RaananW RaananW dismissed sebavan’s stale review April 19, 2023 10:34

Changes were made.

@CedricGuillemet CedricGuillemet merged commit 29860a4 into BabylonJS:master Apr 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolhmj carolhmj carolhmj left review comments

@RaananW RaananW RaananW approved these changes

@Popov72 Popov72 Popov72 approved these changes

@sebavan sebavan Awaiting requested review from sebavan

Assignees
No one assigned
Labels
skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CedricGuillemet @bjsplat @RaananW @Popov72 @carolhmj @sebavan