Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics: Add debug inertia view #13853

Merged
merged 9 commits into from May 17, 2023
Merged

Conversation

carolhmj
Copy link
Contributor

Closes #13775

An example in one of our PGs:
image

@bjsplat
Copy link
Collaborator

bjsplat commented May 12, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 12, 2023

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will wait on @RaananW or @CedricGuillemet review :-)

@CedricGuillemet
Copy link
Contributor

Tested ok with centerOfMassPG. Code looks good but I'm wondering if the display itself is self explanatory.
Inertia is like a core inside (or outside) the shape. Having its display like a collision shape is misleading to me.
Can you please try to replace the wire box display by a scaled sphere ? The idea would be to make the inertia matrix appear like a heavy-solid core inside the physics body.

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have the same comment as Cedric - I am not sure how to understand the visuals. How do I understand inertia from the box?

Copy link
Contributor

@CedricGuillemet CedricGuillemet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after discussing with @carolhmj

@RaananW RaananW merged commit f82486e into BabylonJS:master May 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Physics] Add inertia view to debug
5 participants