Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Physics] Better handling of parented bodies #13914

Merged
merged 9 commits into from Jun 5, 2023

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented May 29, 2023

This PR aims to improve the handling of physical bodies that have parents. For that, we have to decompose the transformation we get from Havok into the parent transformation and the child transformation. A point to check is the stability of this decomposition, especially in very long parenting chains edit: stability is good now!.

This PR will close #13862

@carolhmj carolhmj marked this pull request as draft May 29, 2023 13:49
@bjsplat
Copy link
Collaborator

bjsplat commented May 29, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 29, 2023

@CedricGuillemet
Copy link
Contributor

Tested with different PGs and it's all good to me!!!

@CedricGuillemet CedricGuillemet self-requested a review June 1, 2023 14:16
@carolhmj carolhmj marked this pull request as ready for review June 1, 2023 18:17
@RaananW RaananW merged commit 087e0ee into BabylonJS:master Jun 5, 2023
8 checks passed
@carolhmj carolhmj deleted the physicsDecomposeParentTransform branch August 28, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Physics] Parenting and transform hierarchy
6 participants