Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Physics] Fix warning on copying a mesh with physics body #13951

Merged
merged 1 commit into from Jun 12, 2023

Conversation

carolhmj
Copy link
Contributor

We need to pass the transform node of the body when cloning it.
Related forum issue: https://forum.babylonjs.com/t/havoc-problems-with-parented-meshes/40584/18?u=carolhmj
Test PG: https://playground.babylonjs.com/#Z8HTUN#396
In master, it displays these warnings:
image

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 12, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 12, 2023

@sebavan sebavan enabled auto-merge June 12, 2023 16:56
@sebavan sebavan merged commit b81ef81 into BabylonJS:master Jun 12, 2023
8 checks passed
@carolhmj carolhmj deleted the physicsFixCopy branch July 19, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants