-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XR] First version of Space Warp support #13955
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13955/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13955/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13955/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I am really wondering if we need the update in engine.multiview ?
Thank you @RaananW! FYI, Meta Quest Browser v26.2+ has WebXR Space Warp on by default and doesn't require the flag to be toggled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a couple of nits
This PR contains the XR feature that enables space warp, a feature available in the oculus browser (behind a flag). The feature was suggested as an official WebXR feature - https://pr-preview.s3.amazonaws.com/cabanier/layers/pull/303.html#feature-descriptor-space-warp as part of the XR Layers spec.
Note Code based on the initial version made by @dannysu
Closes #13945