Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XR] First version of Space Warp support #13955

Merged
merged 13 commits into from
Jun 14, 2023
Merged

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jun 13, 2023

This PR contains the XR feature that enables space warp, a feature available in the oculus browser (behind a flag). The feature was suggested as an official WebXR feature - https://pr-preview.s3.amazonaws.com/cabanier/layers/pull/303.html#feature-descriptor-space-warp as part of the XR Layers spec.

Note Code based on the initial version made by @dannysu

Closes #13945

@RaananW RaananW marked this pull request as ready for review June 13, 2023 14:31
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 13, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 13, 2023

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am really wondering if we need the update in engine.multiview ?

@dannysu
Copy link

dannysu commented Jun 14, 2023

Thank you @RaananW! FYI, Meta Quest Browser v26.2+ has WebXR Space Warp on by default and doesn't require the flag to be toggled.

Copy link
Contributor

@carolhmj carolhmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple of nits

packages/dev/core/src/Shaders/velocity.fragement.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Shaders/velocity.fragement.ts Outdated Show resolved Hide resolved
packages/dev/core/src/XR/features/WebXRLayers.ts Outdated Show resolved Hide resolved
@sebavan sebavan merged commit a27d283 into BabylonJS:master Jun 14, 2023
8 checks passed
@RaananW RaananW deleted the spaceWarpXR branch June 14, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XR] Implement Space Warp support
5 participants