Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water material: Fix support for mesh instances #13968

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jun 15, 2023

See https://forum.babylonjs.com/t/water-material-fix/41609/5

It also fixes use of bumpSuperimpose, fresnelSeparate and bumpAffectsReflection, which were not reset when switching their state from true to false.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2023

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woooah :-)

@sebavan sebavan merged commit 36e4b83 into BabylonJS:master Jun 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants