Add Vector2/3/4 tests #13973
Add Vector2/3/4 tests #13973
Conversation
Added tmp and temp to .gitignore
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13973/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13973/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13973/merge#BCU1XR#0 |
(last ones has network issue)
There was a problem hiding this comment.
Very nice! In general, I think it's possible to make the tests cover even more if you check that the vectors used for operations haven't changed in the appropriate case. You could create a boolean variable, set it to true/false in the case it should have changed/not, and check on an after() function according to the variable.
Also fixed some tests that were not checking the right vector
Also adds tmp and temp to .gitignore
Note that this is to make debugging #13699 easier.