Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 5.1 For core #13975

Merged
merged 23 commits into from
Jun 20, 2023
Merged

Typescript 5.1 For core #13975

merged 23 commits into from
Jun 20, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jun 16, 2023

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 16, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 16, 2023

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 16, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 16, 2023

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 16, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 16, 2023

Reviewer - this PR has made changes to one or more package.json files.

@RaananW RaananW marked this pull request as ready for review June 16, 2023 18:13
@RaananW RaananW changed the title [Draft] Typescript 5.1 For core Typescript 5.1 For core Jun 19, 2023
packages/dev/buildTools/src/index.ts Outdated Show resolved Hide resolved
profile.json Outdated Show resolved Hide resolved
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 19, 2023

Reviewer - this PR has made changes to one or more package.json files.

Copy link
Contributor

@carolhmj carolhmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NoiceNiceGIF

@RaananW RaananW merged commit 8e9df43 into BabylonJS:master Jun 20, 2023
8 checks passed
@RaananW RaananW deleted the draftTypescript% branch June 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants