Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gizmo+inspector world/local coordinates switch #14001

Merged
merged 2 commits into from Jun 26, 2023

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Jun 23, 2023

related to #13939
Add the ability to change coordinate system world/local for gizmos.
Also add that switch to the inspector
@PatrickRyanMS Let me know if you have a more suitable icon that this one:
image

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2023

packages/dev/core/src/Gizmos/gizmo.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Gizmos/gizmo.ts Outdated Show resolved Hide resolved
@PatrickRyanMS
Copy link
Member

@CedricGuillemet, can it be two icons based on which mode you are in? For example:

World
image

Local
image

world_local_coordinatesIcons.zip

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a couple nits

packages/dev/core/src/Gizmos/gizmoManager.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Gizmos/positionGizmo.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Gizmos/rotationGizmo.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Gizmos/scaleGizmo.ts Outdated Show resolved Hide resolved
@CedricGuillemet
Copy link
Contributor Author

@CedricGuillemet, can it be two icons based on which mode you are in? For example:

World image

Local image

world_local_coordinatesIcons.zip

Other icons (translate, picking,..) have a color intensity variation only. so icon must be same for world/local and coming from fontawesome.

@RaananW RaananW merged commit 163228d into BabylonJS:master Jun 26, 2023
7 checks passed
@PatrickRyanMS
Copy link
Member

Other icons (translate, picking,..) have a color intensity variation only. so icon must be same for world/local and coming from fontawesome.

Color variation isn't the most accessible option and having color be more than just active/inactive and cover state of the tool is more difficult to internalize so the tooltip will need to do the heavy lifting here. We have been talking about a whole inspector UI redesign so we may need to make due with a fontawesome solution for now and tag a modal for the redesign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants