Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the Bone class #14007

Merged
merged 10 commits into from
Jun 27, 2023
Merged

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jun 26, 2023

It's mainly a reworking of the names, to make things a little clearer for the developer/end-user.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 26, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 26, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 26, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14007/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 26, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14007/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

packages/dev/core/src/Bones/bone.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Bones/bone.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Bones/bone.ts Outdated Show resolved Hide resolved
Popov72 and others added 2 commits June 27, 2023 21:19
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@sebavan sebavan merged commit f8a8014 into BabylonJS:master Jun 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants