Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material: Adds a property to define the relative order in which decals and detailed maps are rendered #14025

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 6, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 6, 2023

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not always doing it after detail map ? I am wondering in which case we d want it before ?

@Popov72
Copy link
Contributor Author

Popov72 commented Jul 6, 2023

See the discussion in the thread, it seems it could be beneficial in some cases, and because it was not difficult to support both and to keep backward compatibility, I added a new property for it.

@sebavan
Copy link
Member

sebavan commented Jul 7, 2023

Let s keep both then and if we need to mention the property too often in the forum lets change the default behavior as it seems pretty far fetch for the current one :-)

@sebavan sebavan merged commit cbb72fc into BabylonJS:master Jul 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decal map: Add an option to apply it before or after the detail map
3 participants