Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sound pileup issue #14047

Merged
merged 12 commits into from
Jul 13, 2023
Merged

Fix sound pileup issue #14047

merged 12 commits into from
Jul 13, 2023

Commits on Jul 12, 2023

  1. Add unit test

    @docEdub
    docEdub committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    411abca View commit details
    Browse the repository at this point in the history

  2. Add unit test

    @docEdub
    docEdub committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    2324d7c View commit details
    Browse the repository at this point in the history

  3. Pass unit test

    @docEdub
    docEdub committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a91f01f View commit details
    Browse the repository at this point in the history

  4. Add unit test

    @docEdub
    docEdub committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    247c91f View commit details
    Browse the repository at this point in the history

  5. Pass unit test

    @docEdub
    docEdub committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d05c2a1 View commit details
    Browse the repository at this point in the history

  6. Use unit test names for Sound object names

    @docEdub
    docEdub committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a68d573 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Cleanup

    @docEdub
    docEdub committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    5ff72bf View commit details
    Browse the repository at this point in the history

  2. Add unit test

    @docEdub
    docEdub committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3821864 View commit details
    Browse the repository at this point in the history

  3. Pass test

    @docEdub
    docEdub committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c461504 View commit details
    Browse the repository at this point in the history

  4. Lint fix

    @docEdub
    docEdub committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f76e01d View commit details
    Browse the repository at this point in the history

  5. Refactor

    @docEdub
    docEdub committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1b24178 View commit details
    Browse the repository at this point in the history

  6. Make Sound._tryToPlayTimeout member only Nullable, not undefined

    @docEdub
    docEdub committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4c1e31f View commit details
    Browse the repository at this point in the history