Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting spatial sound option to false #14048

Conversation

docEdub
Copy link
Contributor

@docEdub docEdub commented Jul 14, 2023

When sounds have the spatialSound option set to true, setting it to false does not disable spatial sound. This change fixes the issue. This change also gets setting the spatialSound option working when using the Sound.updateOptions function.

Reported on forum: https://forum.babylonjs.com/t/what-is-the-expected-behavior-when-i-detach-sound-from-a-mesh/42315

Tested on Chrome browser with playground https://playground.babylonjs.com/#2AH4YH#81.

@docEdub docEdub enabled auto-merge July 14, 2023 00:52
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@docEdub docEdub added the bug label Jul 14, 2023
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2023

@docEdub docEdub requested a review from sebavan July 14, 2023 01:43
@docEdub docEdub merged commit b14c1dc into BabylonJS:master Jul 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants