Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParticleSystem: Fix update function when particle array is not internal array #14053

Merged
merged 1 commit into from Jul 17, 2023
Merged

ParticleSystem: Fix update function when particle array is not internal array #14053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/dev/core/src/Particles/particleSystem.ts
View file
Open in desktop
Expand Up @@ -380,6 +380,8 @@ export class ParticleSystem extends BaseParticleSystem implements IDisposable, I
});
}

const sameParticleArray = particles === this._particles;

for (let index = 0; index < particles.length; index++) {
const particle = particles[index];

Expand Down Expand Up @@ -582,7 +584,9 @@ export class ParticleSystem extends BaseParticleSystem implements IDisposable, I
particle._attachedSubEmitters = null;
}
this.recycleParticle(particle);
index--;
if (sameParticleArray) {
index--;
}
continue;
}
}
Expand Down