Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot tools: Fallback on regular canvas if offscreen canvas not supported #14059

Merged

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jul 18, 2023

See https://forum.babylonjs.com/t/safari-create-screenshot-using-render-target-broken/42512/8

Please wait for comments from the author of the thread to make sure the fix works before merging it! Can be merged!

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

packages/dev/core/src/Misc/dumpTools.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Misc/dumpTools.ts Outdated Show resolved Hide resolved
@sebavan sebavan enabled auto-merge July 18, 2023 15:18
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 18, 2023

@sebavan sebavan merged commit 1dfac07 into BabylonJS:master Jul 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants